Update error type of json api errors #1022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fayi-da
force-pushed
the
fayi/json-api-type-fix
branch
from
ed42dc5 to
18555dc
Compare
Making the type more specific to potentially fix the retry Signed-off-by: fayi-da <fayimora.femibalogun@digitalasset.com>
fayi-da
force-pushed
the
fayi/json-api-type-fix
branch
from
18555dc to
abc2d9f
Compare
Contributor
martinflorian-da
left a comment
martinflorian-da
left a comment
There was a problem hiding this comment.
I'm probably missing something obvious again, but how will a more narrow retry condition make us retry more often?
Contributor
Author
|
Re-posting my comment from the issue The json returned is: {
"status": 400,
"statusText": "",
"body": {
"error": "{\"code\":\"NOT_CONNECTED_TO_ANY_SYNCHRONIZER\",\"cause\":\"This participant is not connected to any synchronizer.\",\"correlationId\":null,\"traceId\":\"68f57a379f608a16d1af4f493b68d56d\",\"context\":{\"participant\":\"participant\",\"definite_answer\":\"false\",\"tid\":\"68f57a379f608a16d1af4f493b68d56d\",\"category\":\"9\"},\"resources\":[],\"errorCategory\":9,\"grpcCodeValue\":9,\"retryInfo\":null,\"definiteAnswer\":null}"
},
"name": "JsonApiError"
}and i can see that |
Contributor
Author
|
Ignore this PR. I'll probably still keep the types but i've seen what the issue is now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the type more specific to potentially fix the retry
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines